Re: [V16,01/15] dt-bindings: mediatek: Add mediatek, mt8195-jpgenc compatible

From: Krzysztof Kozlowski
Date: Wed Sep 28 2022 - 06:04:02 EST


On 28/09/2022 11:32, Irui Wang wrote:
> From: kyrie wu <kyrie.wu@xxxxxxxxxxxx>
>
> Add mediatek,mt8195-jpgenc compatible to binding document.
>
> Signed-off-by: kyrie wu <kyrie.wu@xxxxxxxxxxxx>
> Signed-off-by: irui wang <irui.wang@xxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../media/mediatek,mt8195-jpegenc.yaml | 146 ++++++++++++++++++
> 1 file changed, 146 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
> new file mode 100644
> index 000000000000..5c7ba5c7e598
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-jpegenc.yaml
> @@ -0,0 +1,146 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mt8195-jpegenc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek JPEG Encoder Device Tree Bindings

Drop "Device Tree Bindings"

> +
> +maintainers:
> + - kyrie wu <kyrie.wu@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> +
> +description:
> + MediaTek JPEG Encoder is the JPEG encode hardware present in MediaTek SoCs
> +
> +properties:
> + compatible:
> + const: mediatek,mt8195-jpgenc
> +
> + power-domains:
> + maxItems: 1
> +
> + iommus:
> + maxItems: 4
> + description:
> + Points to the respective IOMMU block with master port as argument, see
> + Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details.
> + Ports are according to the HW.

Missing blank line.

> + dma-ranges:
> + maxItems: 1

Best regards,
Krzysztof