Re: [PATCH v4 2/3] dt-bindings: thermal: add loongson2k thermal binding

[Yinbo Zhu]

在 2022/9/28 下午4:01, Krzysztof Kozlowski 写道:
> On 28/09/2022 05:16, Yinbo Zhu wrote:
> > Add the loongson2k thermal binding with DT schema format using
> > json-schema.
> >
> > Signed-off-by: Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +$id: http://devicetree.org/schemas/thermal/loongson,ls2k-thermal.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Thermal sensors on loongson2k SoCs
> > +
> > +maintainers:
> > +  - zhanghongchen <zhanghongchen@xxxxxxxxxxx>
> > +  - Yinbo Zhu <zhuyinbo@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    const: loongson,ls2k-thermal
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  "#thermal-sensor-cells":
>
> Use same quotes in all places - either ' or "
Thanks for reminding me, I will fix it.
> > +    const: 1> +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - '#thermal-sensor-cells'
>
> With quotes fixed:
I will use "'" uniformly.
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof