Re: [PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr'

From: Jianguo Zhang
Date: Wed Sep 28 2022 - 03:44:10 EST


Dear Krzysztof,

Thanks for your comment.

On Wed, 2022-09-28 at 09:17 +0200, Krzysztof Kozlowski wrote:
> On 27/09/2022 12:44, AngeloGioacchino Del Regno wrote:
>
> > > > OTOH, as Angelo pointed out, handling old and new properties is
> > > > quite
> > > > easy to achieve, so... :)
> > > >
> > >
> > > So, the conclusion is as following:
> > >
> > > 1. add new property 'snps,clk-csr' and document it in binding
> > > file.
> > > 2. parse new property 'snps,clk-csr' firstly, if failed, fall
> > > back to
> > > old property 'clk_csr' in driver.
> > >
> > > Is my understanding correct?
> >
> > Yes, please.
> >
> > I think that bindings should also get a 'clk_csr' with deprecated:
> > true,
> > but that's Krzysztof's call.
>
> The property was never documented, so I think we can skip it as
> deprecated.
>
We will send next version patches according to the conclusion.
> Best regards,
> Krzysztof
>
BRS
Jianguo