Re: [PATCH v2] iwlwifi: Track scan_cmd allocation size explicitly

[Greenman, Gregory]

On Mon, 2022-09-26 at 10:59 +0300, Kalle Valo wrote:
> Kees Cook <keescook@xxxxxxxxxxxx> writes:
> 
> > In preparation for reducing the use of ksize(), explicitly track the
> > size of scan_cmd allocations. This also allows for noticing if the scan
> > size changes unexpectedly. Note that using ksize() was already incorrect
> > here, in the sense that ksize() would not match the actual allocation
> > size, which would trigger future run-time allocation bounds checking.
> > (In other words, memset() may know how large scan_cmd was allocated for,
> > but ksize() will return the upper bounds of the actually allocated memory,
> > causing a run-time warning about an overflow.)
> > 
> > Cc: Gregory Greenman <gregory.greenman@xxxxxxxxx>
> > Cc: Kalle Valo <kvalo@xxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> > Cc: Luca Coelho <luciano.coelho@xxxxxxxxx>
> > Cc: Johannes Berg <johannes.berg@xxxxxxxxx>
> > Cc: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
> > Cc: Miri Korenblit <miriam.rachel.korenblit@xxxxxxxxx>
> > Cc: Ilan Peer <ilan.peer@xxxxxxxxx>
> > Cc: linux-wireless@xxxxxxxxxxxxxxx
> > Cc: netdev@xxxxxxxxxxxxxxx
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> 
> Gregory, can I take this directly to wireless-next?
> 

Acked-by: Gregory Greenman <gregory.greenman@xxxxxxxxx>

Yes, thanks!