Re: [PATCH v2 1/3] watchdog: twl4030_wdt: add missing mod_devicetable.h include

From: Guenter Roeck
Date: Tue Sep 27 2022 - 21:12:05 EST


On Tue, Sep 27, 2022 at 08:46:09AM -0700, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> mod_devicetable.h header. We used to get this definition indirectly via
> inclusion of matrix_keypad.h from twl.h, but we are cleaning up
> matrix_keypad.h from unnecessary includes.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>
> v2: changed from of.h to mod_devicetable.h per Andy Shevchenko
>
> drivers/watchdog/twl4030_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
> index 355e428c0b99..36b4a660928d 100644
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -9,6 +9,7 @@
> #include <linux/types.h>
> #include <linux/slab.h>
> #include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/watchdog.h>
> #include <linux/platform_device.h>
> #include <linux/mfd/twl.h>
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
>