Re: [PATCHv3 1/3] dt-bindings: mmc: synopsys-dw-mshc: document "altr,sysmgr-syscon"

From: Rob Herring
Date: Tue Sep 27 2022 - 18:05:41 EST


On Mon, Sep 26, 2022 at 11:49 AM Dinh Nguyen <dinguyen@xxxxxxxxxx> wrote:
>
>
>
> On 9/26/22 10:35, Krzysztof Kozlowski wrote:
> > On 26/09/2022 16:09, Dinh Nguyen wrote:
> >> +allOf:
> >> + - $ref: "synopsys-dw-mshc-common.yaml#"
> >> +
> >> + - if:
> >> + properties:
> >> + compatible:
> >> + contains:
> >> + const:
> >> + - altr,socfpga-dw-mshc
> >> + then:
> >> + required:
> >> + - altr,sysmgr-syscon
> >
> > else:
> > properties:
> > altr,sysmgr-syscon: false
> > and then you will probably see the warnings leading to error in syntax
> > (const is not an array)...
> >
>
> Hmm, okay. I ran dt_binding_check and did not see the warning. I'll
> check it again.

Indeed, it does not warn. An array is allowed here as you could have a
constant array value. Expect a warning soon though, as I'm working on
adding one.

Rob