Re: [PATCH v4 5/7] sched/topology: Introduce sched_numa_hop_mask()

[Yury Norov]

On Tue, Sep 27, 2022 at 05:45:10PM +0100, Valentin Schneider wrote:
> On 25/09/22 08:00, Yury Norov wrote:
> > On Fri, Sep 23, 2022 at 04:55:40PM +0100, Valentin Schneider wrote:
> >> +/**
> >> + * sched_numa_hop_mask() - Get the cpumask of CPUs at most @hops hops away.
> >> + * @node: The node to count hops from.
> >> + * @hops: Include CPUs up to that many hops away. 0 means local node.
> >> + *
> >> + * Requires rcu_lock to be held. Returned cpumask is only valid within that
> >> + * read-side section, copy it if required beyond that.
> >> + *
> >> + * Note that not all hops are equal in distance; see sched_init_numa() for how
> >> + * distances and masks are handled.
> >> + *
> >> + * Also note that this is a reflection of sched_domains_numa_masks, which may change
> >> + * during the lifetime of the system (offline nodes are taken out of the masks).
> >> + */
> >
> > Since it's exported, can you declare function parameters and return
> > values properly?
> >
> 
> I'll add a bit about the return value; what is missing for the parameters?

My bad, scratch this.