Re: [PATCH v10 15/27] scripts: checkpatch: diagnose uses of `%pA` in the C side as errors

From: Greg Kroah-Hartman
Date: Tue Sep 27 2022 - 11:03:44 EST


On Tue, Sep 27, 2022 at 03:14:46PM +0200, Miguel Ojeda wrote:
> The `%pA` format specifier is only intended to be used from Rust.
>
> `checkpatch.pl` already gives a warning for invalid specificers:
>
> WARNING: Invalid vsprintf pointer extension '%pA'
>
> This makes it an error and introduces an explanatory message:
>
> ERROR: Invalid vsprintf pointer extension '%pA' - '%pA' is only intended to be used from Rust code
>
> Suggested-by: Kees Cook <keescook@xxxxxxxxxxxx>
> Co-developed-by: Alex Gaynor <alex.gaynor@xxxxxxxxx>
> Signed-off-by: Alex Gaynor <alex.gaynor@xxxxxxxxx>
> Co-developed-by: Wedson Almeida Filho <wedsonaf@xxxxxxxxxx>
> Signed-off-by: Wedson Almeida Filho <wedsonaf@xxxxxxxxxx>
> Co-developed-by: Joe Perches <joe@xxxxxxxxxxx>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> ---
> scripts/checkpatch.pl | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>