Re: [PATCH v10 10/27] rust: add `macros` crate

From: Geert Stappers
Date: Tue Sep 27 2022 - 10:05:23 EST


On Tue, Sep 27, 2022 at 04:48:05PM +0300, Konstantin Shelekhin wrote:
> On Tue, Sep 27, 2022 at 03:14:41PM +0200, Miguel Ojeda wrote:
> [...]
> > For instance, the `module!` macro that is used by Rust modules
> > is implemented here. It allows to easily declare the equivalent
> > information to the `MODULE_*` macros in C modules, e.g.:
> >
> > module! {
> > type: RustMinimal,
> > name: b"rust_minimal",
> > author: b"Rust for Linux Contributors",
> > description: b"Rust minimal sample",
> > license: b"GPL",
> > }
> [...]
>
> I remember that there was a switch from &u8 to &str on master branch a
> while ago. Why this patch was reverted? Strings are really better here.

ASCII versus UTF8


Groeten
Geert Stappers
--
Silence is hard to parse