Re: [PATCH 3/4] mfd: twl4030-irq: add missing device.h include

From: Andy Shevchenko
Date: Tue Sep 27 2022 - 08:25:24 EST


On Mon, Sep 26, 2022 at 10:22:15PM -0700, Dmitry Torokhov wrote:
> The driver is using "struct device" and therefore needs to include
> device.h header. We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 4f576f0160a9..87496c1cb8bc 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -14,6 +14,7 @@
> * by syed khasim <x0khasim@xxxxxx>
> */
>
> +#include <linux/device.h>
> #include <linux/export.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
>

--
With Best Regards,
Andy Shevchenko