Re: [PATCH] ASoC: soc-pcm: fix fe and be race when accessing substream->runtime

From: Eugeniu Rosca
Date: Tue Sep 27 2022 - 07:56:34 EST


Hello Amadeusz,

On Di, Sep 27, 2022 at 09:34:49 +0200, Amadeusz Sławiński wrote:
> On 9/26/2022 6:35 PM, Eugeniu Rosca wrote:
> >From: xiao jin <jin.xiao@xxxxxxxxx>
> >
> >After start of fe and be, fe might go to close without triggering
> >STOP, and substream->runtime is freed. However, be is still at
> >START state and its substream->runtime still points to the
> >freed runtime.
> >
>
> Well if it is being freed, maybe pointer should be set to NULL instead in
> place that happens?
>

As soon as the agreement is reached that the patch is still
relevant/useful on the latest vanilla, I think this review
finding will receive proper attention.

Thanks,
Eugeniu