Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems

[Marc Zyngier]

On Tue, 27 Sep 2022 03:51:04 -0400,
"Arnd Bergmann" <arnd@xxxxxxxx> wrote:
> 
> On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote:
> 
> > @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[];
> > 
> >  void __init irqchip_init(void)
> >  {
> > +#ifdef CONFIG_OF_IRQ
> >  	of_irq_init(__irqchip_of_table);
> > +#endif
> >  	acpi_probe_device_table(irqchip);
> >  }
> 
> I think that #ifdef should be in the include/linux/of_irq.h
> header, with an empty inline function in the #else path.

Agreed. Please keep the C code free of #ifdefs if at all possible.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.