RE: [v2] drm/msm: add null checks for drm device to avoid crash during probe defer

[Vinod Polimera]

> -----Original Message-----
> From: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> Sent: Tuesday, September 27, 2022 2:33 PM
> To: Vinod Polimera <vpolimer@xxxxxxxxxxxxxxxx>;
> dmitry.baryshkov@xxxxxxxxxx; Vinod Polimera (QUIC)
> <quic_vpolimer@xxxxxxxxxxx>; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-arm-
> msm@xxxxxxxxxxxxxxx; freedreno@xxxxxxxxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Cc: dianders@xxxxxxxxxxxx; vpolimer@xxxxxxxxxxx; Abhinav Kumar
> <abhinavk@xxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> swboyd@xxxxxxxxxxxx; kalyant@xxxxxxxxxxx
> Subject: Re: [v2] drm/msm: add null checks for drm device to avoid crash
> during probe defer
> 
> WARNING: This email originated from outside of Qualcomm. Please be wary
> of any links or attachments, and do not enable macros.
> 
> Hello Vinod and Dmitry,
> 
> On 9/27/22 09:31, Vinod Polimera wrote:
> >> -----Original Message-----
> >> From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> >> Sent: Friday, August 26, 2022 2:11 PM
> >> To: Vinod Polimera (QUIC) <quic_vpolimer@xxxxxxxxxxx>; dri-
> >> devel@xxxxxxxxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx;
> >> freedreno@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx; robdclark@xxxxxxxxx;
> >> dianders@xxxxxxxxxxxx; vpolimer@xxxxxxxxxxx;
> swboyd@xxxxxxxxxxxx;
> >> kalyant@xxxxxxxxxxx
> >> Subject: Re: [v2] drm/msm: add null checks for drm device to avoid crash
> >> during probe defer
> >>
> 
> [...]
> 
> >> Vinod, do we still want to pursue this fix? If so, could you please
> >> update it according to the comment.
> >>
> 
> I don't think this patch is needed anymore, since AFAICT the issue has
> been fixed by commit 0a58d2ae572a ("drm/msm: Make .remove and
> .shutdown
> HW shutdown consistent") which is already in the drm/drm-next branch.
Yes , Issue will be fixed with the  commit 0a58d2ae572a ("drm/msm: Make .remove and .shutdown) . Hence  we can  drop this patch.
> 
> --
> Best regards,
> 
> Javier Martinez Canillas
> Core Platforms
> Red Hat

- Vinod P.