RE: [PATCH] selftests/resctrl: Return MBA check result and make it to output message

[tan.shaopeng@xxxxxxxxxxx]

Hi Reinette,

Thanks for your advice.

> On my side this patch arrived as an unnumbered sixth patch forming part of a
> five patch series.

In next version, I will add this patch into patch series.

> On 9/13/2022 6:51 PM, Shaopeng Tan wrote:
> > Since MBA check result is not returned, the MBA test result message is
> > always output as OK regardless of whether the MBA check result is true
> > or fail.
> 
> fail -> false?

It is false.

> I think it should be either succeed/fail or true/false.
> 
> >
> > Make output message to be "not ok" if MBA check result is failed.
> >
> > This patch is based on Linux v6.0-rc5
> 
> This should not be part of the changelog but instead be below the "---".

Thanks.

> >
> > Signed-off-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx>
> > ---
> 
> Thank you very much for catching this. The fix looks good, I only have nitpicks
> about the changelog.
> 
> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Thanks.

Best Regards,
Shaopeng