Re: [PATCH] perf record: Fix segmentation fault in record__read_lost_samples()

From: Arnaldo Carvalho de Melo
Date: Mon Sep 26 2022 - 15:16:52 EST


Em Mon, Sep 26, 2022 at 10:54:43PM +0800, Leo Yan escreveu:
> On Mon, Sep 26, 2022 at 01:59:29PM +0100, Arnaldo Carvalho de Melo wrote:
>
> [...]
>
> > > > Fixes: a49aa8a54e86 ("perf record: Read and inject LOST_SAMPLES events")
> > > > Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> > >
> > > Thanks for the fix and sorry for the inconvenience.
> > > Actually I sent the same fix a few weeks ago.
> > >
> > > https://lore.kernel.org/r/20220909235024.278281-1-namhyung@xxxxxxxxxx
> >
> > collecting it now, and adding that Fixes from Leo's patch, ok?
>
> Yeah, I think it's good to add Fixes tag. Just remind, actually
> Namhyung has mentioned Fixed tag in above link:
>
> "I didn't add a Fixes tag as it's not sent to Linus yet. But in case you want it.
>
> Fixes: a49aa8a54e86 ("perf record: Read and inject LOST_SAMPLES events")
> "

I'll add it.

Sometimes I think about combining fixes with patches in my tree that
didn't made it into Linus tree yet, so that we avoid having problems
with 'git bisect', but I also try not to rebase acme/perf/core.

Perhaps in the future 'git bisect' will look at Fixes: tags :-)

- Arnaldo