Re: [PATCH -next] IB/hfi1,PCI: Fix missing pci_disable_device() in probe and remove

From: Jason Gunthorpe
Date: Mon Sep 26 2022 - 13:57:50 EST


On Thu, Sep 22, 2022 at 10:46:01AM +0800, ruanjinjie wrote:
> Replace pci_enable_device() with pcim_enable_device(),
> pci_disable_device() and pci_release_regions() will be
> called in release automatically.
>
> Signed-off-by: ruanjinjie <ruanjinjie@xxxxxxxxxx>
> ---
> drivers/infiniband/hw/hfi1/pcie.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Please no, at LPC it seems the general consensus is that the devm
varients were a Bad Idea. If the code as-is is correct then lets leave
it alone.

Jason