Re: [RFC] clk: qcom: common: Detach the power domain at the end of probe

From: Bjorn Andersson
Date: Mon Sep 26 2022 - 13:13:19 EST


On Thu, Aug 04, 2022 at 05:37:48PM +0300, Dmitry Baryshkov wrote:
> On Thu, 4 Aug 2022 at 13:35, Abel Vesa <abel.vesa@xxxxxxxxxx> wrote:
> >
> > None of the CCs actually need the PD attached to their device,
> > but rather some GDSCs registered by those CCs need that PD as a parent
> > in order to propagate power gating and the performance state.
> >
> > So lets detach the PD from the CC right at the end of probe, after
> > everything has been successfully set up.
>
> Would it still be possible to read the clock registers if we detach
> the device from the domain?
> I think it was the original issue behind putting the dispcc/videocc
> into the MMCX domain: to be able to poke into the clock registers,
> which are gated by the MMCX.
>

I share the understanding, that on several modern platforms e.g. dispcc
was shown to depend on mmcx and the associated gcc abh clock being
enabled.

@Abel, could you please verify this on 8250/8350/8450?

Regards,
Bjorn

>
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
>
>
> --
> With best wishes
> Dmitry