Re: [PATCH v1 2/2] Input: matrix_keypad - replace header inclusions by forward declarations
From: Andy Shevchenko
Date: Mon Sep 26 2022 - 08:14:18 EST
On Fri, Sep 23, 2022 at 12:03:00PM -0700, Dmitry Torokhov wrote:
> On Fri, Sep 23, 2022 at 09:46:32PM +0300, Andy Shevchenko wrote:
> > When the data structure is only referred by pointer, compiler may not need
> > to see the contents of the data type. Thus, we may replace header inclusions
> > by respective forward declarations.
...
> > +struct device;
> > +struct input_dev;
>
> This results in a ton of compile errors. While I believe this change is
> a good one, we need to fix users of this include first.
Indeed, sorry for breaking things (I compile-tested with limited drivers
enabled). I will look into LKP reports and will fix the users.
--
With Best Regards,
Andy Shevchenko