Re: [PATCH net] rhashtable: fix crash due to mm api change

From: Florian Westphal
Date: Mon Sep 26 2022 - 06:46:20 EST


Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> Only in the case of kvzalloc. We expect kzalloc to fail, that's
> why it gets NOWARN. There is no sane reason for kvzalloc to fail
> so it should warn.

To me a WARN() only has one purpose:
It will get reported to mailing list and a developer can use that
to develop a patch/fix.

In memory allocation failure, there is no bug, so nothing to fix,
so WARN is useless.