Re: [PATCH v3 2/3] m68k: virt: generate new RNG seed on reboot

From: Jason A. Donenfeld
Date: Mon Sep 26 2022 - 06:30:08 EST


On 9/26/22, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> Hi Jason,
>
> On Fri, Sep 23, 2022 at 7:03 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
>> Rather than rebooting into a system with no entropy, regenerate the RNG
>> seed before rebooting, so that the new system has a fresh seed.
>>
>> Fixes: a1ee38ab1a75 ("m68k: virt: Use RNG seed from bootinfo block")
>> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
>
> Thanks for your patch!
>
> I still doubt this is actually guaranteed to work, as the memory containing
> the bootinfo might be overwritten during normal operation.

Thus far, I'm unable to make it *not* work. So this seems like
actually an improvement?

Jason