On Sat, Sep 24, 2022 at 9:24 AM Jason Yan <yanaijie@xxxxxxxxxx> wrote:
Hi Jason,
Sas address conversion and comparation is widely used in libsas and
drivers. However they are all opencoded and to avoid the line spill over
80 columns, are mostly split into multi-lines.
To make the code easier to read, introduce some helpers with clearer
semantics and replace the opencoded segments with them.
v1->v2:
First factor out sas_find_attached_phy() and replace LLDDs's code
with it.
Remove three too simple helpers.
Rename the helpers with 'sas_' prefix.
Thx for doing this.
Jason Yan (8):These 4 look good to me.
scsi: libsas: introduce sas_find_attached_phy() helper
scsi: pm8001: use sas_find_attached_phy() instead of open coded
scsi: mvsas: use sas_find_attached_phy() instead of open coded
scsi: hisi_sas: use sas_find_attathed_phy() instead of open coded
Reviewed-by: Jack Wang <jinpu.wang@xxxxxxxxx>
scsi: libsas: introduce sas address comparation helpersThese helpers are too simple to replace, we add more loc in the end.
scsi: libsas: use sas_phy_match_dev_addr() instead of open coded
scsi: libsas: use sas_phy_addr_same() instead of open coded
scsi: libsas: use sas_phy_match_port_addr() instead of open coded
.
drivers/scsi/hisi_sas/hisi_sas_main.c | 12 ++------
drivers/scsi/libsas/sas_expander.c | 40 ++++++++++++++++-----------
drivers/scsi/libsas/sas_internal.h | 17 ++++++++++++
drivers/scsi/mvsas/mv_sas.c | 15 +++-------
drivers/scsi/pm8001/pm8001_sas.c | 16 ++++-------
include/scsi/libsas.h | 2 ++
6 files changed, 54 insertions(+), 48 deletions(-)
--
2.31.1