Re: [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties

From: Guenter Roeck
Date: Sun Sep 25 2022 - 10:30:28 EST


On Wed, May 25, 2022 at 09:46:05AM +0900, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>
> v3: doesn't remove timeout-sec.
> v2: send to linux-watchdog.
>
> .../bindings/watchdog/toshiba,visconti-wdt.yaml | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..eba083822d1f 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,16 @@ additionalProperties: false
>
> examples:
> - |
> + #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
> soc {
> #address-cells = <2>;
> #size-cells = <2>;
>
> - wdt_clk: wdt-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <150000000>;
> - #clock-cells = <0>;
> - };
> -
> - watchdog@28330000 {
> + wdt: watchdog@28330000 {
> compatible = "toshiba,visconti-wdt";
> reg = <0 0x28330000 0 0x1000>;
> - clocks = <&wdt_clk>;
> timeout-sec = <20>;
> + clocks = <&pismu TMPV770X_CLK_WDTCLK>;
> };
> };