Re: [PATCH] pcmcia: at91_cf: switch to using gpiod API

From: Linus Walleij
Date: Sun Sep 25 2022 - 08:25:35 EST


On Sat, Sep 24, 2022 at 4:19 PM Dominik Brodowski
<linux@xxxxxxxxxxxxxxxxxxxx> wrote:

> From: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>
> Subject: [PATCH] pcmcia: remove AT91RM9200 Compact Flash driver
>
> As noted by Arnd Bergmann, "we used to have three drivers for the same
> hardware (pcmcia, pata and ide), and only the pcmcia driver remained
> in the tree after drivers/ide/ was removed and pata_at91 did not get
> converted to DT". "There is no dts file in tree that actually declares
> either of them, so chances are that nobody is actually using the CF
> slot on at91 any more."[1]
>
> On this rationale, remove the AT91RM9200 Compact Flash driver, which
> also assists in reaching "the goal of stopping exporting OF-specific
> APIs of gpiolib".[2]
>
> [1] https://lore.kernel.org/lkml/68c63077-848b-45f5-8aca-ed995391f2b6@xxxxxxxxxxxxxxxx/
> [2] https://lore.kernel.org/lkml/Yy6d7TjqzUwGQnQa@penguin/
>
> Signed-off-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx>

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

If someone actually has an AT91 board with this hardware and
want to be able to use it by converting this driver to device tree,
this is the time to step up.

Yours,
Linus Walleij