Re: [PATCH] video: fbdev: tridentfb: Remove the unused function shadowmode_off()

[Helge Deller]

On 9/14/22 12:23, Jiapeng Chong wrote:
> The function shadowmode_off() is defined in the tridentfb.c file, but not
> called elsewhere, so delete this unused function.
>
> drivers/video/fbdev/tridentfb.c:1131:20: warning: unused function 'shadowmode_off'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2154
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>

applied.

Thanks,
Helge


> ---
>   drivers/video/fbdev/tridentfb.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
> index f9c3b1d38fc2..2154dd5e37bd 100644
> --- a/drivers/video/fbdev/tridentfb.c
> +++ b/drivers/video/fbdev/tridentfb.c
> @@ -1128,11 +1128,6 @@ static inline void shadowmode_on(struct tridentfb_par *par)
>   	write3CE(par, CyberControl, read3CE(par, CyberControl) | 0x81);
>   }
>
> -static inline void shadowmode_off(struct tridentfb_par *par)
> -{
> -	write3CE(par, CyberControl, read3CE(par, CyberControl) & 0x7E);
> -}
> -
>   /* Set the hardware to the requested video mode */
>   static int tridentfb_set_par(struct fb_info *info)
>   {