Re: [PATCH v4 0/7] Fixups for s2idle on various Rembrandt laptops

From: Rafael J. Wysocki
Date: Sat Sep 24 2022 - 13:08:16 EST


On Wed, Sep 21, 2022 at 10:40 PM Mario Limonciello
<mario.limonciello@xxxxxxx> wrote:
>
> It was reported that an ASUS Rembrandt laptop has problems with seemingly
> unrelated ACPI events after resuming from s2idle. Debugging the issue
> proved it's because ASUS has ASL that is only called when using the
> Microsoft GUID, not the AMD GUID.
>
> This is a bug from ASUS firmware but this series reworks the s2idle
> handling for AMD to allow accounting for this in a quirk.
>
> Additionally as this is a problem that may pop up again on other models
> add a module parameter that can be used to try the Microsoft GUID on a
> given system.
>
> This module parameter intentionally applies to both Intel and AMD systems
> as the same problem could potentially exist on Intel systems that support
> both the Intel GUID or the Microsoft GUID.
>
> v3->v4:
> * Absorb tags
> * minor URL correction
> * Rename module parameter per Rafael's request
> v2->v3:
> * Add more systems
> v1->v2:
> * Add two more systems that are reported to be helped by this series.
>
> Mario Limonciello (7):
> acpi/x86: s2idle: Move _HID handling for AMD systems into structures
> acpi/x86: s2idle: If a new AMD _HID is missing assume Rembrandt
> acpi/x86: s2idle: Add module parameter to prefer Microsoft GUID
> acpi/x86: s2idle: Add a quirk for ASUS TUF Gaming A17 FA707RE
> acpi/x86: s2idle: Add a quirk for ASUS ROG Zephyrus G14
> acpi/x86: s2idle: Add a quirk for Lenovo Slim 7 Pro 14ARH7
> acpi/x86: s2idle: Add a quirk for ASUSTeK COMPUTER INC. ROG Flow X13

All applied as 6.1 material, thanks!

> drivers/acpi/x86/s2idle.c | 136 +++++++++++++++++++++++++++++++-------
> 1 file changed, 112 insertions(+), 24 deletions(-)
>
> --