Re: [PATCH 2/2] PCI: mvebu: switch to using gpiod API

From: Linus Walleij
Date: Wed Sep 14 2022 - 08:48:56 EST


On Wed, Sep 14, 2022 at 2:10 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> On Wed, Sep 14, 2022 at 12:35 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> > I think this is one of those occasions where we should merge
> > the new defines, and then send Linus Torvalds a sed script
> > that he can run at the end of the merge window to change all
> > gpiod_set_value(...., 1) -> gpiod_set_state(...., GPIOD_ASSERTED);
> > everywhere.
>
> We can also let Linus know that we'll do it ourselves late in the
> merge window and send a separate PR on Saturday before rc1?

I suppose, it's a matter of taste. It's probably easier for him to
check the sanity of a sed script than of all the changes it generates
though.

Yours,
Linus Walleij