Re: [PATCH v2 05/13] gpiolib: acpi: Add wake_capable parameter to acpi_dev_gpio_irq_get_by

[Andy Shevchenko]

On Mon, Sep 12, 2022 at 04:13:09PM -0600, Raul E Rangel wrote:
> The ACPI spec defines the SharedAndWake and ExclusiveAndWake share type
> keywords. This is an indication that the GPIO IRQ can also be used as a
> wake source. This change exposes the wake_capable bit so drivers can
> correctly enable wake functionality instead of making an assumption.

...

> -	ret = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(dev), "irq-gpios", 0);
> +	ret = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(dev), "irq-gpios", 0,
> +				       NULL);
>  	if (ret < 0)
>  		return ret;

Looking at these changes, can't we first introduce

	int acpi_dev_gpio_irq_get_by_name(struct acpi_device *adev, const char *name);

convert users, and then add wake stuff to the basic function.
In such case you will make less invasive main part of the idea.

-- 
With Best Regards,
Andy Shevchenko