RE: [PATCH v5 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes

From: Kani, Toshi
Date: Wed Sep 07 2022 - 20:33:04 EST


On Monday, September 5, 2022 9:25 AM, Jia He wrote:
> -void ghes_edac_unregister(struct ghes *ghes)
> +static void ghes_edac_unregister(struct ghes *ghes)
> {
> struct mem_ctl_info *mci;
> unsigned long flags;
>
> - if (!ghes_edac_force_enable)
> - return;
> -

I am not familiar with this original check. Assuming it is safe to
delete it now (as you mentioned in other email w/o description),
I suggest adding some description to the commit log.

At high-level, the patch looks good to me.
Acked-by: Toshi Kani <toshi.kani@xxxxxxx>

Toshi