Re: [PATCH v1 2/5] fpga: dfl: Move the DFH definitions

[matthew . gerlach]

On Tue, 6 Sep 2022, Andy Shevchenko wrote:

> On Tue, Sep 06, 2022 at 12:04:23PM -0700, matthew.gerlach@xxxxxxxxxxxxxxx wrote:
> > From: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@xxxxxxxxxxxxxxx>
> >
> > Moving the DFH register offset and register definitions from
> > drivers/fpga/dfl.h to include/linux/dfl.h.  These definitions
>
> Single space?

Sorry for the old habit. I will make it one space.

> > need to be accessed by dfl drivers that are outside of
> > drivers/fpga.
>
> ...
>
> > +#define DFH			0x0
> > +#define GUID_L			0x8
> > +#define GUID_H			0x10
> > +#define NEXT_AFU		0x18
>
> While at it, you may make them same width, like "0x08".

The same width does look better.  Thanks for the suggestion.

Matthew Gerlach
> --
> With Best Regards,
> Andy Shevchenko