Re: [mani-mhi:mhi-next 2/3] drivers/bus/mhi/host/pci_generic.c:734:60: error: assignment of member 'irq' in read-only object

[Jeff Johnson]

On 9/7/2022 9:45 AM, Manivannan Sadhasivam wrote:
> On Wed, Sep 07, 2022 at 09:47:42PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git mhi-next
> > head:   0a3b31f6259f4849e4e93731d4c8d7910be072a7
> > commit: 4a98958ca237a4b7974ea1ec2092b3666bdd26ab [2/3] bus: mhi: host: make mhi_controller_config::event_cfg const
> > config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220907/202209072144.lWoBySRH-lkp@xxxxxxxxx/config)
> > compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
> > reproduce (this is a W=1 build):
> >          # https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git/commit/?id=4a98958ca237a4b7974ea1ec2092b3666bdd26ab
> >          git remote add mani-mhi https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git
> >          git fetch --no-tags mani-mhi mhi-next
> >          git checkout 4a98958ca237a4b7974ea1ec2092b3666bdd26ab
> >          # save the config file
> >          mkdir build_dir && cp config build_dir/.config
> >          make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> >
> > All errors (new ones prefixed by >>):
> >
> >     drivers/bus/mhi/host/pci_generic.c: In function 'mhi_pci_get_irqs':
> > > > drivers/bus/mhi/host/pci_generic.c:734:60: error: assignment of member 'irq' in read-only object
> >       734 |                         mhi_cntrl_config->event_cfg[i].irq = 0;
>
> Ah, so this is why I didn't make it constant in the first place...
> Dropped the patch now.
>
> Thanks,
> Mani

I believe it should be const in the MHI config, but in this case the 
declaration in drivers/bus/mhi/host/pci_generic.c can't be const.

Let me respin the patch with this in mind.