Re: [PATCH v17 12/12] selftests/bpf: Add tests for dynamic pointers parameters in kfuncs

From: Kumar Kartikeya Dwivedi
Date: Wed Sep 07 2022 - 12:05:32 EST


On Wed, 7 Sept 2022 at 17:00, Roberto Sassu
<roberto.sassu@xxxxxxxxxxxxxxx> wrote:
>
> From: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
>
> Add tests to ensure that only supported dynamic pointer types are accepted,
> that the passed argument is actually a dynamic pointer, that the passed
> argument is a pointer to the stack, and that bpf_verify_pkcs7_signature()
> correctly handles dynamic pointers with data set to NULL.
>
> The tests are currently in the deny list for s390x (JIT does not support
> calling kernel function).
>
> Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>
> ---

Just a minor nit: you could probably use invalid flags value other
than 1, since most likely the next valid flag value will be 1, which
will require changing this again. LGTM otherwise.

Acked-by: Kumar Kartikeya Dwivedi <memxor@xxxxxxxxx>