Re: [PATCH v2] MIPS: octeon: Get rid of preprocessor directives around RESERVE32

[Thomas Bogendoerfer]

On Tue, Sep 06, 2022 at 10:32:39AM +0200, Alexander A Sverdlin wrote:
> From: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> 
> Some of them were pointless because CONFIG_CAVIUM_RESERVE32 is now always
> defined, some were not enough (Yu Zhao reported
> "Failed to allocate CAVIUM_RESERVE32 memory area" error).
> 
> Removing the directives allows for compiler coverage of RESERVE32 code and
> replacing one of [always-true] "ifdef" with a compiler conditional fixes
> the [cosmetic] error message.
> 
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> ---
> 
> Changelog:
> v2:
> * Reduced the scope of addr variable
> 
>  arch/mips/cavium-octeon/executive/cvmx-cmd-queue.c |  4 ----
>  arch/mips/cavium-octeon/setup.c                    | 27 +++++++++-------------

applied to mips-fixes with

Fixes: 3e3114ac460e ("MIPS: Introduce CAVIUM_RESERVE32 Kconfig option")

added.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]