Re: [PATCH linux-next] ocxl: Remove the unneeded result variable

[Andrew Donnellan]

On Tue, 2022-09-06 at 07:20 +0000, cgel.zte@xxxxxxxxx wrote:
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
> 
> Return the value opal_npu_spa_clear_cache() directly instead of
> storing
> it in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>

Acked-by: Andrew Donnellan <ajd@xxxxxxxxxxxxx>

> ---
>  arch/powerpc/platforms/powernv/ocxl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powernv/ocxl.c
> b/arch/powerpc/platforms/powernv/ocxl.c
> index 27c936075031..629067781cec 100644
> --- a/arch/powerpc/platforms/powernv/ocxl.c
> +++ b/arch/powerpc/platforms/powernv/ocxl.c
> @@ -478,10 +478,8 @@ EXPORT_SYMBOL_GPL(pnv_ocxl_spa_release);
>  int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int
> pe_handle)
>  {
>         struct spa_data *data = (struct spa_data *) platform_data;
> -       int rc;
>  
> -       rc = opal_npu_spa_clear_cache(data->phb_opal_id, data->bdfn,
> pe_handle);
> -       return rc;
> +       return opal_npu_spa_clear_cache(data->phb_opal_id, data-
> >bdfn, pe_handle);
>  }
>  EXPORT_SYMBOL_GPL(pnv_ocxl_spa_remove_pe_from_cache);
>  

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@xxxxxxxxxxxxx   IBM Australia Limited