Re: [PATCH] libbpf: Clean up legacy bpf maps declaration in bpf_helpers

[Song Liu]

On Mon, Sep 5, 2022 at 1:38 AM Liuxin(EulerOS) <liuxin350@xxxxxxxxxx> wrote:
>
> Legacy bpf maps declaration were no longer supported in Libbpf 1.0,
> so it was time to remove the definition of bpf_map_def in
> bpf_helpers.h.
>
> LINK:[1] https://github.com/libbpf/libbpf/wiki/Libbpf:-the-road-to-v1.0
>
> Signed-off-by: Liu Xin<liuxin350@xxxxxxxxxx>

This looks a little weird.

From: "Liuxin(EulerOS)" <liuxin350@xxxxxxxxxx>

Please fix your name in git config:

Otherwise,

Acked-by: Song Liu <song@xxxxxxxxxx>

> ---
> tools/lib/bpf/bpf_helpers.h | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/tools/lib/bpf/bpf_helpers.h b/tools/lib/bpf/bpf_helpers.h
> index 867b73483..9cad13e7f 100644
> --- a/tools/lib/bpf/bpf_helpers.h
> +++ b/tools/lib/bpf/bpf_helpers.h
> @@ -167,18 +167,6 @@ bpf_tail_call_static(void *ctx, const void *map, const __u32 slot)
> }
> #endif
>
> -/*
> - * Helper structure used by eBPF C program
> - * to describe BPF map attributes to libbpf loader
> - */
> -struct bpf_map_def {
> -       unsigned int type;
> -       unsigned int key_size;
> -       unsigned int value_size;
> -       unsigned int max_entries;
> -       unsigned int map_flags;
> -} __attribute__((deprecated("use BTF-defined maps in .maps section")));
> -
> enum libbpf_pin_type {
>         LIBBPF_PIN_NONE,
>         /* PIN_BY_NAME: pin maps by name (in /sys/fs/bpf by default) */
> --
> 2.33.0