Re: [PATCH linux-next] drm/amd/display: Remove the unneeded result variable

From: Rodrigo Siqueira Jordao
Date: Tue Sep 06 2022 - 12:17:12 EST




On 2022-09-02 03:54, cgel.zte@xxxxxxxxx wrote:
From: zhang songyi <zhang.songyi@xxxxxxxxxx>

Return the enable_link_dp() directly instead of storing it in another
redundant variable.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: zhang songyi <zhang.songyi@xxxxxxxxxx>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index f9b798b7933c..4ab27e231337 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -2077,11 +2077,7 @@ static enum dc_status enable_link_edp(
struct dc_state *state,
struct pipe_ctx *pipe_ctx)
{
- enum dc_status status;
-
- status = enable_link_dp(state, pipe_ctx);
-
- return status;
+ return enable_link_dp(state, pipe_ctx);
}
static enum dc_status enable_link_dp_mst(

LGTM,

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>

and applied to amd-staging-drm-next.

Thanks
Siqueira