Re: [PATCH] drm/amd/display: fix memory leak when using debugfs_lookup()

From: Greg Kroah-Hartman
Date: Tue Sep 06 2022 - 11:51:53 EST


On Tue, Sep 06, 2022 at 10:52:28AM -0400, Rodrigo Siqueira Jordao wrote:
>
>
> On 2022-09-02 09:10, Greg Kroah-Hartman wrote:
> > On Fri, Sep 02, 2022 at 03:01:05PM +0200, Greg Kroah-Hartman wrote:
> > > When calling debugfs_lookup() the result must have dput() called on it,
> > > otherwise the memory will leak over time. Fix this up by properly
> > > calling dput().
> > >
> > > Cc: Harry Wentland <harry.wentland@xxxxxxx>
> > > Cc: Leo Li <sunpeng.li@xxxxxxx>
> > > Cc: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
> > > Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> > > Cc: "Christian König" <christian.koenig@xxxxxxx>
> > > Cc: "Pan, Xinhui" <Xinhui.Pan@xxxxxxx>
> > > Cc: David Airlie <airlied@xxxxxxxx>
> > > Cc: Daniel Vetter <daniel@xxxxxxxx>
> > > Cc: Wayne Lin <Wayne.Lin@xxxxxxx>
> > > Cc: hersen wu <hersenxs.wu@xxxxxxx>
> > > Cc: Wenjing Liu <wenjing.liu@xxxxxxx>
> > > Cc: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>
> > > Cc: Thelford Williams <tdwilliamsiv@xxxxxxxxx>
> > > Cc: Fangzhi Zuo <Jerry.Zuo@xxxxxxx>
> > > Cc: Yongzhi Liu <lyz_cs@xxxxxxxxxx>
> > > Cc: Mikita Lipski <mikita.lipski@xxxxxxx>
> > > Cc: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> > > Cc: Bhanuprakash Modem <bhanuprakash.modem@xxxxxxxxx>
> > > Cc: Sean Paul <seanpaul@xxxxxxxxxxxx>
> > > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > ---
> >
> > Despite a zillion cc: items, I forgot to cc: stable on this. Can the
> > maintainer add that here, or do you all want me to resend it with that
> > item added?
> >
> > thanks,
> >
> > greg k-h
>
> Hi Greg,
>
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@xxxxxxx>
>
> Is 'Cc: stable@xxxxxxxxxxxxxxx' enough here? I can make this change before I
> merge it into amd-staging-drm-next.

Yes, please add the cc: stable@ line to the body of the patch, sorry I
forgot that.

thanks,

greg k-h