Re: [PATCH V2] perf dlfilter: dlfilter-show-cycles: Fix types for print format

From: Arnaldo Carvalho de Melo
Date: Tue Sep 06 2022 - 08:59:07 EST


Em Mon, Sep 05, 2022 at 10:47:35AM +0300, Adrian Hunter escreveu:
> Avoid compiler warning about format %llu that expects long long unsigned
> int but argument has type __u64.
>
> Fixes: c3afd6e50fce ("perf dlfilter: Add dlfilter-show-cycles")
> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---
>
>
> Changes in V2:
>
> Add fixes tag

Thanks, applied.

- Arnaldo


>
> tools/perf/dlfilters/dlfilter-show-cycles.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/dlfilters/dlfilter-show-cycles.c b/tools/perf/dlfilters/dlfilter-show-cycles.c
> index 9eccc97bff82..6d47298ebe9f 100644
> --- a/tools/perf/dlfilters/dlfilter-show-cycles.c
> +++ b/tools/perf/dlfilters/dlfilter-show-cycles.c
> @@ -98,9 +98,9 @@ int filter_event_early(void *data, const struct perf_dlfilter_sample *sample, vo
> static void print_vals(__u64 cycles, __u64 delta)
> {
> if (delta)
> - printf("%10llu %10llu ", cycles, delta);
> + printf("%10llu %10llu ", (unsigned long long)cycles, (unsigned long long)delta);
> else
> - printf("%10llu %10s ", cycles, "");
> + printf("%10llu %10s ", (unsigned long long)cycles, "");
> }
>
> int filter_event(void *data, const struct perf_dlfilter_sample *sample, void *ctx)
> --
> 2.25.1

--

- Arnaldo