RE: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234

[Sandipan Patra]

Hi Krzysztof,

 > > +             pwm2: pwm@3290000 {
> > +                     compatible = "nvidia,tegra194-pwm",
> > +                                  "nvidia,tegra186-pwm";
> 
> This does not match bindings. Either DTS or bindings need to be fixed.

Thanks for reviewing the patches.

Tegra234 uses same compatible as Tegra194.
And also we can clear "nvidia,tegra186-pwm" from the Tegra234 pwm compatible list.
I will update binding doc and push new patch.


Thanks & Regards,
Sandipan



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Tuesday, August 30, 2022 3:20 PM
> To: Sandipan Patra <spatra@xxxxxxxxxx>; thierry.reding@xxxxxxxxx;
> Jonathan Hunter <jonathanh@xxxxxxxxxx>; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> tegra@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Cc: Bibek Basu <bbasu@xxxxxxxxxx>; Krishna Yarlagadda
> <kyarlagadda@xxxxxxxxxx>
> Subject: Re: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234
> 
> External email: Use caution opening links or attachments
> 
> 
> On 29/08/2022 14:44, Sandipan Patra wrote:
> > Tegra234 has eight single-channel PWM controllers, one of them in the
> > AON block.
> >
> > Signed-off-by: Sandipan Patra <spatra@xxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 84
> > ++++++++++++++++++++++++
> >  1 file changed, 84 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > index 81a0f599685f..c2dc651f0842 100644
> > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> > @@ -840,6 +840,90 @@
> >                       #pwm-cells = <2>;
> >               };
> >
> > +             pwm2: pwm@3290000 {
> > +                     compatible = "nvidia,tegra194-pwm",
> > +                                  "nvidia,tegra186-pwm";
> 
> This does not match bindings. Either DTS or bindings need to be fixed.
> 
> Best regards,
> Krzysztof