Re: [PATCH v3 2/4] arm64: dts: apple: t8103: Add MCA and its support

[Martin Povišer]

Ciao Janne, thanks for the comments and fixes.

> On 6. 9. 2022, at 0:39, Janne Grunau <janne@xxxxxxxxxx> wrote:
> 
> On 2022-08-24 18:07:13 +0200, Martin Povišer wrote:
>> Add the MCA I2S transceiver node and its supporting NCO, ADMAC nodes.
>> 
>> Signed-off-by: Martin Povišer <povik+lin@xxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/apple/t8103-jxxx.dtsi | 4 ++
>> arch/arm64/boot/dts/apple/t8103.dtsi | 73 +++++++++++++++++++++++
>> 2 files changed, 77 insertions(+)


>> +		/*
>> +		 * This is a fabulated representation of the input clock
>> +		 * to NCO since we don't know the true clock tree.
>> +		 */
>> +		nco_clkref: clock-ref {
> 
> clocks are not valid inside "simple-bus", the node name "clock-ref" 
> conflicts in "/", maybe use "clock-nco"?

I would smuggle ‘ref’ or something to that effect into the name,
otherwise sure, let’s do it.

Martin