Re: [PATCH v1 09/11] regulator: bd9576: switch to using devm_fwnode_gpiod_get()

[Matti Vaittinen]

On 9/5/22 13:40, Andy Shevchenko wrote:
> On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov
> <dmitry.torokhov@xxxxxxxxx> wrote:
> > I would like to stop exporting OF-specific devm_gpiod_get_from_of_node()
> > so that gpiolib can be cleaned a bit, so let's switch to the generic
> > fwnode property API.
> >
> > While at it switch the rest of the calls to read properties in
> > bd957x_probe() to the generic device property API as well.
>
> With or without below addressed,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> >
> > diff --git a/drivers/regulator/bd9576-regulator.c b/drivers/regulator/bd9576-regulator.c
> > index aa42da4d141e..393c8693b327 100644
> > --- a/drivers/regulator/bd9576-regulator.c
> > +++ b/drivers/regulator/bd9576-regulator.c
> > @@ -12,6 +12,7 @@
> >   #include <linux/module.h>
> >   #include <linux/of.h>
> >   #include <linux/platform_device.h>
> > +#include <linux/property.h>
> >   #include <linux/regulator/driver.h>
> >   #include <linux/regulator/machine.h>
> >   #include <linux/regulator/of_regulator.h>
> > @@ -939,8 +940,8 @@ static int bd957x_probe(struct platform_device *pdev)
> >          }
> >
> >          ic_data->regmap = regmap;
> > -       vout_mode = of_property_read_bool(pdev->dev.parent->of_node,
> > -                                        "rohm,vout1-en-low");
> > +       vout_mode = device_property_read_bool(pdev->dev.parent,
> > +                                             "rohm,vout1-en-low");
>
> They all using parent device and you may make code neater by adding
>
>    struct device *parent = pdev->dev.parent;

This is a matter of personal preference. I prefer seeing 
pdev->dev.parent - as it is more obvious (to me) what the 'pdev' is than 
what 'parent' would be.

I'd use the local variable only when it shortens at least one of the 
lines so that we avoid splitting it. After that being said - I'm not 
going to argue over this change either if one who is improving the 
driver wants to use the "helper" variable here.

Best Regards
	-- Matti


--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~