Re: [PATCH v2 4/5] riscv: use BIT() marco for cpufeature probing

[Conor.Dooley]

On 05/09/2022 12:10, Heiko Stuebner wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Using the appropriate BIT macro makes the code better readable.
> 
> Suggested-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>

Missing the cover-letter with the changelog?
At least, I didn't get it in my inbox. Either way,

Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> ---
>   arch/riscv/kernel/cpufeature.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/riscv/kernel/cpufeature.c b/arch/riscv/kernel/cpufeature.c
> index 729f7a218093..08f7445985dc 100644
> --- a/arch/riscv/kernel/cpufeature.c
> +++ b/arch/riscv/kernel/cpufeature.c
> @@ -289,10 +289,10 @@ static u32 __init_or_module cpufeature_probe(unsigned int stage)
>          u32 cpu_req_feature = 0;
> 
>          if (cpufeature_probe_svpbmt(stage))
> -               cpu_req_feature |= (1U << CPUFEATURE_SVPBMT);
> +               cpu_req_feature |= BIT(CPUFEATURE_SVPBMT);
> 
>          if (cpufeature_probe_zicbom(stage))
> -               cpu_req_feature |= (1U << CPUFEATURE_ZICBOM);
> +               cpu_req_feature |= BIT(CPUFEATURE_ZICBOM);
> 
>          return cpu_req_feature;
>   }
> --
> 2.35.1
>