RE: [PATCH] crypto: aspeed: fix build module error

From: Neal Liu
Date: Sun Sep 04 2022 - 22:40:14 EST


> -----Original Message-----
> From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, September 2, 2022 6:29 PM
> To: Neal Liu <neal_liu@xxxxxxxxxxxxxx>
> Cc: David S . Miller <davem@xxxxxxxxxxxxx>; Joel Stanley <joel@xxxxxxxxx>;
> Andrew Jeffery <andrew@xxxxxxxx>; linux-aspeed@xxxxxxxxxxxxxxxx;
> linux-crypto@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; BMC-SW <BMC-SW@xxxxxxxxxxxxxx>; kernel
> test robot <lkp@xxxxxxxxx>
> Subject: Re: [PATCH] crypto: aspeed: fix build module error
>
> On Mon, Aug 29, 2022 at 03:20:35PM +0800, Neal Liu wrote:
> >
> > obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) += aspeed-hace-hash.o
> > hace-hash-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_HASH) :=
> aspeed-hace-hash.o
> > obj-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) +=
> aspeed-hace-crypto.o
> > hace-crypto-$(CONFIG_CRYPTO_DEV_ASPEED_HACE_CRYPTO) :=
> > aspeed-hace-crypto.o
>
> Why are these two files being included twice? I think the obj- lines should be
> deleted.
>
> Thanks,

I'll send new patch within removing the redundant obj- lines.
Thanks.

> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt