Re: [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory

[Ceraolo Spurio, Daniele]

On 9/4/2022 12:29 AM, Usyskin, Alexander wrote:
> > > +static void pxp_is_ready(struct mei_cl_device *cldev)
> > > +{
> > > +	struct mei_device *bus = cldev->bus;
> > > +
> > > +	switch (bus->pxp_mode) {
> > > +	case MEI_DEV_PXP_READY:
> > > +	case MEI_DEV_PXP_DEFAULT:
> > > +		cldev->do_match = 1;
> > Can you explain why you set do_match = 1 with MEI_DEV_PXP_DEFAULT ?
> > AFAIU MEI_DEV_PXP_DEFAULT means that we haven't even started to
> > initialize PXP, so it seems weird to match in that scenario.
> >
> > Apart from this, the patch LGTM.
> >
> > Daniele
> MEI_DEV_PXP_DEFAULT is a state for the legacy PXP solution that uses the same firmware client
> and have no need in special initialization.

makes sense. Could use a comment, but anyway:

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx>

Daniele

>