Re: [PATCH v4] phy: rockchip-inno-usb2: Return zero after otg sync

[Samuel Holland]

On 9/2/22 1:45 PM, Peter Geis wrote:
> The otg sync state patch reuses the ret variable, but fails to set it to
> zero after use. This leads to a situation when the otg port is in
> peripheral mode where the otg phy aborts halfway through setup.  It also
> fails to account for a failure to register the extcon notifier. Fix this
> by using our own variable and skipping otg sync in case of failure.
> 
> Fixes: 8dc60f8da22f ("phy: rockchip-inno-usb2: Sync initial otg state")
> Reported-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>
> Reported-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>
> Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx>
> Tested-by: Michael Riesch <michael.riesch@xxxxxxxxxxxxxx>
> Tested-by: Markus Reichl <m.reichl@xxxxxxxxxxxxx>

Reviewed-by: Samuel Holland <samuel@xxxxxxxxxxxx>