Re: [GIT pull] objtool/urgent for v5.19-rc1

[Masahiro Yamada]

Hi Linus,

On Mon, Jun 6, 2022 at 2:14 AM Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, Jun 5, 2022 at 2:30 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> >
> > diff --git a/scripts/Makefile.build b/scripts/Makefile.build
> > index 06400504150b..6a663b27b286 100644
> > --- a/scripts/Makefile.build
> > +++ b/scripts/Makefile.build
> > @@ -218,7 +218,7 @@ objtool_args =                                                              \
> >         $(if $(CONFIG_SLS), --sls)                                      \
> >         $(if $(CONFIG_STACK_VALIDATION), --stackval)                    \
> >         $(if $(CONFIG_HAVE_STATIC_CALL_INLINE), --static-call)          \
> > -       --uaccess                                                       \
> > +       $(if $(CONFIG_HAVE_UACCESS_VALIDATION), --uaccess)              \
> >         $(if $(linked-object), --link)                                  \
> >         $(if $(part-of-module), --module)                               \
> >         $(if $(CONFIG_GCOV_KERNEL), --no-unreachable)
>
> Since this clashed with the Kbuild cleanups I just merged, I looked at
> it and threw up in my mouth a little.
>
> Not a new problem, but can we do something like that attached, perhaps?
>
> Untested, but looks trivially obvious. FamousLastWords(tm).
>
>                   Linus

A nice idea.

I also cleaned up scripts/Makefile.vmlinux_o in a similar way,
and submitted a patch.

https://lore.kernel.org/lkml/20220902130846.654526-1-masahiroy@xxxxxxxxxx/T/#u

I will send it in the next MW.


--
Best Regards
Masahiro Yamada