Re: [PATCH 4/4] riscv: check for kernel config option in t-head memory types errata

[Conor.Dooley]

On 02/09/2022 02:06, Guo Ren wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Is it a Fixes?

Looks like one to me, seems a fixes tag would be good to
have here... Either way:
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> 
> On Fri, Sep 2, 2022 at 6:28 AM Heiko Stuebner <heiko@xxxxxxxxx> wrote:
>>
>> The t-head variant of page-based memory types should also check first
>> for the enabled kernel config option.
>>
>> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
>> ---
>>   arch/riscv/errata/thead/errata.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c
>> index a6f4bd8ccf3f..902e12452821 100644
>> --- a/arch/riscv/errata/thead/errata.c
>> +++ b/arch/riscv/errata/thead/errata.c
>> @@ -17,6 +17,9 @@
>>   static bool errata_probe_pbmt(unsigned int stage,
>>                                unsigned long arch_id, unsigned long impid)
>>   {
>> +       if (!IS_ENABLED(CONFIG_ERRATA_THEAD_PBMT))
>> +               return false;
>> +
>>          if (arch_id != 0 || impid != 0)
>>                  return false;
>>
>> --
>> 2.35.1
>>
> 
> 
> --
> Best Regards
>   Guo Ren