Re: [char-misc:char-misc-testing 20/24] drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error: 'PCI_IRQ_ALL_TYPES' undeclared

[Greg KH]

On Fri, Sep 02, 2022 at 08:30:22AM +0000, Kumaravel.Thiagarajan@xxxxxxxxxxxxx wrote:
> 
> 
> > -----Original Message-----
> > From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Friday, September 2, 2022 12:33 PM
> > To: kernel test robot <lkp@xxxxxxxxx>; Kumaravel Thiagarajan - I21417
> > <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>; kbuild-all@xxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [char-misc:char-misc-testing 20/24]
> > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > 'PCI_IRQ_ALL_TYPES' undeclared
> > 
> > 
> > On Fri, Sep 02, 2022 at 06:13:10AM +0800, kernel test robot wrote:
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > misc.git char-misc-testing
> > > head:   51ea3f9e9017b47c15b37a200d8e81e36a169b70
> > > commit: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d [20/24] misc:
> > microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-
> > function endpoint of pci1xxxx device.
> > > config: sh-allmodconfig
> > > (https://download.01.org/0day-
> > ci/archive/20220902/202209020641.mPiacQE
> > > P-lkp@xxxxxxxxx/config)
> > > compiler: sh4-linux-gcc (GCC) 12.1.0
> > > reproduce (this is a W=1 build):
> > >         wget https://raw.githubusercontent.com/intel/lkp-
> > tests/master/sbin/make.cross -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-
> > misc.git/commit/?id=3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > >         git remote add char-misc
> > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
> > >         git fetch --no-tags char-misc char-misc-testing
> > >         git checkout 3f359bf61b6f65be474fbcdf557cd412f19d0f1d
> > >         # save the config file
> > >         mkdir build_dir && cp config build_dir/.config
> > >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> > > make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash
> > > drivers/misc/mchp_pci1xxxx/
> > >
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > >
> > > All error/warnings (new ones prefixed by >>):
> > >
> > >    drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c: In function
> > 'gp_aux_bus_probe':
> > > >> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c:87:52: error:
> > > >> 'PCI_IRQ_ALL_TYPES' undeclared (first use in this function)
> > >       87 |         retval = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> > >          |                                                    ^~~~~~~~~~~~~~~~~
> > 
> > Odd.
> > 
> > Ah, the driver needs to have a "depends on PCI" for the Kconfig file.
> > 
> > Kumaravel, can you send an add-on patch for this issue with the proper
> > "Reported-by:" line as asked for above?
> Greg, for the add-on patch, can I modify only the KConfig file which you can apply to
> commit id: 3f359bf61b6f65be474fbcdf557cd412f19d0f1d of char-misc-testing?

Yes, I can merge them together.

thanks,

greg k-h