RE: [PATCH net] net: fec: add pm_qos support on imx6q platform

From: Wei Fang
Date: Thu Sep 01 2022 - 22:06:30 EST




> -----Original Message-----
> From: Paolo Abeni <pabeni@xxxxxxxxxx>
> Sent: 2022年9月1日 15:18
> To: Wei Fang <wei.fang@xxxxxxx>; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net] net: fec: add pm_qos support on imx6q platform
>
> On Tue, 2022-08-30 at 15:01 +0800, wei.fang@xxxxxxx wrote:
> > From: Wei Fang <wei.fang@xxxxxxx>
> >
> > There is a very low probability that tx timeout will occur during
> > suspend and resume stress test on imx6q platform. So we add pm_qos
> > support to prevent system from entering low level idles which may
> > affect the transmission of tx.
> >
> > Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
>
> Since this IMHO causes a significal behavior change I suggest to target the
> net-next tree, does that fit you?
>
In my opinion, the patch is to fix a bug rather than add a new feature, so I think
it should be net tree. But it's fine that if the majority think the net-next is more
suitable.

> Additionally, it would be great if you could provide in the changelog the
> references to the relevant platform documentation and (even rough) power
> consumption delta estimates.
>