Re: [PATCH] KVM: fix memoryleak in kvm_init()

From: Sean Christopherson
Date: Thu Sep 01 2022 - 19:21:20 EST


On Fri, Sep 02, 2022, Paolo Bonzini wrote:
> On 8/30/22 23:36, Sean Christopherson wrote:
> > On Tue, Aug 23, 2022, Miaohe Lin wrote:
> > > When alloc_cpumask_var_node() fails for a certain cpu, there might be some
> > > allocated cpumasks for percpu cpu_kick_mask. We should free these cpumasks
> > > or memoryleak will occur.
> > >
> > > Fixes: baff59ccdc65 ("KVM: Pre-allocate cpumasks for kvm_make_all_cpus_request_except()")
> > > Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> > > ---
> >
> > Pushed to branch `for_paolo/6.1` at:
> >
> > https://github.com/sean-jc/linux.git
> >
> > Unless you hear otherwise, it will make its way to kvm/queue "soon".
> >
> > Note, the commit IDs are not guaranteed to be stable.
>
> Hmm, I was going to merge these memory leak fixes for 6.0, but no big deal
> since they're mostly theoretical anyway.

Take them, I wasn't sure and was anticipating possibly dropping them anyways. I
can easily adjust, and was deliberately a little greedy for these technically-a-bug
memory leaks so that we would't miss them by thinking the other would grab 'em.