Re: [PATCH] livepatch: Add a missing newline character in klp_module_coming()

[Petr Mladek]

On Tue 2022-08-30 19:28:55, Zhen Lei wrote:
> The error message is not printed immediately because it does not end with
> a newline character.
> 
> Before:
> root@localhost:~# insmod vmlinux.ko
> insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
> 
> After:
> root@localhost:~# insmod vmlinux.ko
> [   43.982558] livepatch: vmlinux.ko: invalid module name
> insmod: ERROR: could not insert module vmlinux.ko: Invalid parameters
> 
> Fixes: dcf550e52f56 ("livepatch: Disallow vmlinux.ko")
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>

Great catch! The message is not pushed to the console because
the line is not finished and might be eventually extended by pr_cont().

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

The fix is trivial. I have pushed it into livepatching/livepatching.git,
branch for-6.1/fixes.

Best Regards,
Petr